Skip to content

Improve the code quality with tools #31

Open
@oliverklee

Description

@oliverklee

Let's improve code quality by checking the code with tools for common flaws and against established standards. This should also make contributing to this project easier, and reduce the amount of work required to do PR reviews.

I'll take care of this.

  • add Composer script for PHP linting
  • make all PHP files strict
  • add PHP_CodeSniffer and Composer scripts for this
  • add PHP_CodeSniffer to the CI pipeline
  • enforce that all files are strict via PHP_CodeSniffer
  • autoformat all files with PhpStorm
  • make the code PSR-12-compliant
  • enforce PSR-12 in the CI pipeline
  • add PHPStan (including Composer scripts and checks in the CI pipeline)
  • fix all level-0 PHPStan-reported flaws
  • fix all level-1 PHPStan-reported flaws
  • fix all level-2 PHPStan-reported flaws
  • fix all level-3 PHPStan-reported flaws
  • fix all level-4 PHPStan-reported flaws
  • fix all level-5 PHPStan-reported flaws
  • fix all level-6 PHPStan-reported flaws
  • fix all level-7 PHPStan-reported flaws
  • fix all level-8 PHPStan-reported flaws
  • fix all level-9 PHPStan-reported flaws

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions