be less chatty when run non-interactively #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a minimum threshold for writing the progress updates like: - Scanning for nodes in ways - Block M/N - Writing tile M of N The threshold applies when run non-interactively, for example, when in a GitHub action. (Related to this, I've learned that GitHub Actions get angry at you when your action generates 500 MB of logs. :) Interactive use should be unaffected.
cldellow
force-pushed
the
less-chatty-non-interactive
branch
from
c864ab9 to
4425255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a minimum threshold for writing the progress updates like:
The threshold only applies when run non-interactively, for example, when in a GitHub action. It shoots for one line of output for every 1% of progress. I was motivated to do this because processing North America in an action generated > 500 MB of logs and seemed to cause GitHub to kill the action.
Interactive use should be unaffected. Windows is always treated as interactive, as I'm not sure how to test for that.