Add support for Amazon Linux 2023 #3784
Conversation
There was a problem hiding this comment.
First off: Could you squash the three commits into one, since the last three are only fixups?
More substantially: Will you be around to fix this, if this breaks? Also, to see whether this breaks, it would be preferable if CI were added to it. It can skip all the unsupported cases, if you only support building on a specific distro, that's also fine, but what's not covered by CI will never be noticed if it works or not (Mageia? Mandriva?) and it will bitrot.
| from mkosi.log import die | ||
|
|
||
|
|
||
| class Installer(fedora.Installer): |
There was a problem hiding this comment.
So, since this is something of a Fedora spin-off, should this get a Fedora tools tree by default, like CentOS or Ubuntu? If not, why not?
There was a problem hiding this comment.
Squashed the commits, sorry about the miss there.
While I am not a core maintainer of Amazon Linux 2023, I am employed by amazon, until then I will be around to support it and can work with maintainers in Amazon Linux 2023 to fix any issues if they arise.
I will add support for CI, and setting the default tools tree for this, and update this PR in a couple of days.
Signed-off-by: Vasudevan Perumal <[email protected]>
|
I actually have a PR sitting locally for this as well, the reason I haven't pushed it yet is because of rpm-software-management/dnf5#1321, when building amazon linux images dnf5 tried to do things with amazon cdn urls with '+'s in them and that did not go well. AFAIK that issue still happens, can you verify you can build amazon linux images with dnf5? If not I'd prefer that bug in dnf5 is fixed first since we're looking to only support dnf5 and not dnf anymore. |
|
Got it, I have been using a debian tools tree to build amazon linux 2023, so I have did not hit this issue pattern, I guess the CI matrix would have caught this :). I am trying to find some spare time to close the loop on this. I will test if this works with dnf5 if it does not, I'll look into if what I can do to move this forward. |
Amazon Linux 2023 is similar to Azure linux and Fedora.
We would like to start building System Extension images of Amazon Linux 2023 and adopting for aws workflows, and use mkosi for this process.
Some quirks are Amazon Linux 2023 is a new distribution in itself, it's not a version like a successor of AL2, so we only support building Amazon Linux 2023, as AL2 is going to be end of life by 2026 so it is not worth supporting AL2.
Also Amazon Linux 2023 is not supported for bare metal devices, we only focus on supporting for VMs, and system extension images, and nspawn containers.
Amazon Linux 2023 also does not have the packages available to be a tool tree for mkosi, you can use other distribution as tool tree to build Amazon Linux 2023
I have attached the build output as a test output as reference: