Skip to content

Update docs, remove zen, make relative URLs #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Update docs, remove zen, make relative URLs #1110

merged 1 commit into from
Jun 17, 2019

Conversation

larixer
Copy link
Member

@larixer larixer commented Jun 17, 2019

This PR removes Zen mentions and uses relative URLs for documentation links

@larixer larixer merged commit 89657da into master Jun 17, 2019
@larixer larixer deleted the update-docs branch June 17, 2019 09:33
@strefethen
Copy link

@Vlasenko I'd definitely be interested in better understanding why zen was removed? There are a lot of changes in the commit and the above comment doesn't offer enough context to understand the rational. Seems like this is a pretty big change that's not well explained.

@larixer
Copy link
Member Author

larixer commented Jun 19, 2019

@strefethen Why zen was removed. Zen is a tool that checks project's dependencies in package.json and tries to generate good default Webpack config which can further be customized. This PR actually takes Webpack config generated by Zen and stores the config into kit source code itself. What has been dropped is config autogeneration. Config autogeneration has obvious pros that users don't have to spend time to write and maintain "default good" webpack config. But there is also a price to pay when you need more flexibility with tweaking webpack config. Yes, zen uses webpack-merge and different strategies to make config tweaking very flexible, though there are cases that they are not flexible enough though. For example try to add code splitting support into zen generated webpack config. Or try to have completely different strategy with using mini-css-webpack-plugin. The changes like these will require essential changes to webpack config.

So the main rationale is to provide more means to tweak webpack config as much as you want and as easy as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants