-
-
Notifications
You must be signed in to change notification settings - Fork 22
Docker support & example usage #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updating surname to my new name! - enabling linters that were disabled for go modules 1.11 - docker-compose example use of the dockerfile - update travis to go 1.12
- use PORT from the environment if it's available - pluralize examples directory - port flag to string so http(s) values can be used - initial prettification of the example index.html, more to come
- new logo, SVG! - drop the old simple example in favor of combining them - shared static directory for a pretty index on the examples - docker-compose moved to root - contributing guide baseline
- finishing up the static index.html - cleaning up some pre-commit hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Feature
Add support for docker! Auto build to Docker Hub
Additional features
.editorconfig
,.gitattributes
,.markdown-lint.yml
,.pre-commit-config.yaml
for dev environment sanityCONTRIBUTING.md
because everyone needs one, right?flags.Port
is now a string - Using an int didn't allow for usinghttp
andhttps
shorthands