-
-
Notifications
You must be signed in to change notification settings - Fork 200
Allow node 10.19 #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow node 10.19 #912
Conversation
Note that Node 10 EOLs at 2021-04-30: https://nodejs.org/en/about/releases/ |
That's the EOL date from node maintainers. There are other ppl that take over maintenance after them, eg from Ubuntu LTS or RHEL. |
An indirect dependency of Encore (webpack-manifest-plugin) doesn't support 10.19 anymore, I guess that's the reason behind the bump. |
I don't think using nodejs (or php, python, ...) binaries from Ubuntu (or other any OS) official repositories is a good idea. Also, I'm not a big fan for lowering the version range "just for you", because of your OS constraints. IMO, this is not a problem Encore should have to deal with. And as @tgalopin said, webpack-manifest-plugin requires at least Node 10.22.1. |
Thanks for spotting the dep that triggered the bump. Here is a PR to fix it too: shellscape/webpack-manifest-plugin#247 We don't have to wait for this other PR to merge this one. Bumping when there is no technical reason to do so is doing DRM and forcing ppl (not just me this time) to spend more time doing extra work. We can definitely be more friendly towards our communities by relaxing minimum versions too. |
Thanks Nicolas! |
Unfortunately shellscape/webpack-manifest-plugin#247 has been rejected :'( |
Should we revert this PR? |
This was bumped in #645
Ubuntu LTS ships node 10.19 by default.
If we can, let's save ppl (aka me) from installing yet another ppa.