Skip to content

Add maxOptions to autocomplete with remote data #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

kevinmade
Copy link

@kevinmade kevinmade commented Jun 4, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
License MIT

This fixes an issue where the autocomplete component stops loading additional results after 50 due to default limit. The maxOptions value has been set to null to allow loading more than 50 options from the autocomplete_url.

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Autocomplete
controller.js 16.7 kB / 3.96 kB 16.72 kB0% / 3.97 kB0%

Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kevinmade ! Thank you for this suggestion.

You need to make your changes on the source code of the controller.

Here, you changes are done on the dist file, that will be re-computed from the source everytime someone make a change, and your suggestion will be lost.

Also, it will be easier to review with a bit of context, some link to documentation or source code impacted, etc.

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Jun 4, 2025
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Jun 5, 2025
@kevinmade
Copy link
Author

Before

Screencast.from.2025-06-05.15-00-22.mp4

After

Screencast.from.2025-06-05.15-00-48.mp4

@kevinmade kevinmade requested a review from smnandre June 5, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants