Skip to content

[Map] Optional leaflet tilelayer #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Map] Optional leaflet tilelayer #2779

merged 1 commit into from
May 28, 2025

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented May 28, 2025 •
edited by Kocal
Loading

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #...
License MIT

Comment from #2445 (comment)

@dannyvw dannyvw requested a review from Kocal as a code owner May 28, 2025 09:32
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Map labels May 28, 2025
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Map (Bridge Leaflet)
map_controller.d.ts 2.03 kB / 667 B 2.04 kB0% / 672 B+1% 📈
map_controller.js 9.65 kB / 2.58 kB 9.71 kB+1% 📈 / 2.59 kB0%

Kocal
Kocal reviewed May 28, 2025
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a new feature, can you add a changelog entry? 🙏🏻

@Kocal
Copy link
Member

Kocal commented May 28, 2025

Changelog and documentation updated

@Kocal Kocal added the Feature New Feature label May 28, 2025
@Kocal
Copy link
Member

Kocal commented May 28, 2025

Thank you @dannyvw.

@Kocal Kocal merged commit 825476f into symfony:2.x May 28, 2025
22 of 23 checks passed
@Kocal Kocal deleted the map-tilelayer branch May 28, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal left review comments

Assignees
No one assigned
Labels
Feature New Feature Map Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyvw @carsonbot @Kocal