[Notify] Added options to Notification
#1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernie76
changed the title
|
this PR connected to this PR symfony/symfony#54961 |
Kocal
reviewed
May 20, 2024
src/Notify/assets/dist/controller.js
Outdated
| @@ -65,5 +71,4 @@ default_1.values = { | |||
| hub: String, | |||
| topics: Array, | |||
| }; | |||
|
|
|||
| export { default_1 as default }; | |||
ernie76
changed the title
|
PR on the Symfony side has been merged now. |
stof
reviewed
Apr 4, 2025
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||
|
PR on the symfony side symfony/symfony#60140 |
smnandre
reviewed
Apr 4, 2025
smnandre
reviewed
Apr 4, 2025
Kocal
reviewed
Apr 4, 2025
Kocal
approved these changes
Apr 4, 2025
carsonbot
added
Status: Reviewed
Kocal
changed the title
options to Notification
…-notifier Co-authored-by: Simon André <[email protected]>
|
Thank you @ernie76. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added body, icon, tag ,renotify for desktop notifications
This pull-request are need changes in src/Symfony/Component/Notifier/Bridge/Mercure/MercureOptions.php. I have made a pull request there too.