Elfinder bundle 8 #179
Elfinder bundle 8 #179
Conversation
helios-ag/fm-elfinder-bundle uses Studio-42/elFinder instead of helios-ag/ElFinderPHP (https://github.com/helios-ag/FMElfinderBundle/releases/tag/8.0)
|
This solves #178 |
| @@ -31,7 +30,7 @@ | |||
| /** | |||
| * @author Sjoerd Peters <[email protected]> | |||
| */ | |||
| class PhpcrDriver extends ElFinderVolumeDriver | |||
| class PhpcrDriver extends \elFinderVolumeDriver | |||
There was a problem hiding this comment.
this will break with older versions of elfinder bundle, however. can you bump the version in composer to the one that uses the new elfinder library?
There was a problem hiding this comment.
I added helios-ag/fm-elfinder-bundle < 8.0 to the conflict section.
| @@ -54,7 +53,7 @@ class PhpcrDriver extends ElFinderVolumeDriver | |||
| /** | |||
| * @var array | |||
| */ | |||
| private $options; | |||
| protected $options; | |||
There was a problem hiding this comment.
I'm getting this otherwise:
PHP Fatal error: Access level to Symfony\Cmf\Bundle\MediaBundle\Adapter\ElFinder\PhpcrDriver::$options must be protected (as in class elFinderVolumeDriver) or weaker in .../vendor/symfony-cmf/media-bundle/src/Adapter/ElFinder/PhpcrDriver.php on line 34
There was a problem hiding this comment.
hm, so that means we collide on that field. does the new volume driver also have a constructor that we should be calling? how does it use the options field? we probably need to rename this field as we would overwrite the options of the base class...
There was a problem hiding this comment.
Yes its weird. Thing is, with the previous ElFinderVolumeDriver (https://github.com/helios-ag/ElFinderPHP/blob/master/src/Driver/ElFinderVolumeDriver.php) it was done in the same way.
They talk about this issue here too symfony/symfony#25353.
There was a problem hiding this comment.
we merge the options with the options of the parent class. hm, whatever. i guess its fine then.
|
i merged this as it seems reasonably save. |
|
i am however hesitant to create a release of an unmaintained bundle. does it work for you to have composer.json reference the exact commit id that we have in master now? |
|
@dbu sure that's fine for me. If others will run into this issue they will find this pull request and can solve this way. |
helios-ag/fm-elfinder-bundle uses Studio-42/elFinder instead of helios-ag/ElFinderPHP (https://github.com/helios-ag/FMElfinderBundle/releases/tag/8.0)