-
Notifications
You must be signed in to change notification settings - Fork 167
Typed event data + async event handlers #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 63.28% // Head: 63.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 63.28% 63.09% -0.20%
==========================================
Files 54 55 +1
Lines 8952 8995 +43
==========================================
+ Hits 5665 5675 +10
- Misses 3287 3320 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was an erroneous GenericNode bound on the wrong type generic
@lukechu10 |
We can still change it but I am personally in favor of |
@lukechu10 |
Closes #241 and #506
Async event handlers somehow do not type check yet.This is a breaking change because closures now accept different types as arguments depending on the event used. This is also a breaking change because invalid event names are no longer allowed, and the event structs must be used explicitly when using the builder API.