Skip to content

Refactor reopen log signal #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Refactor reopen log signal #5778

merged 2 commits into from
May 20, 2025

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented May 20, 2025

No longer using the SIGRTMIN signal; instead, the logs will be reopened upon receiving SIGWINCH. SIGRTMIN is a feature unique to Linux.

matyhtf added 2 commits May 20, 2025 23:40
…ed upon receiving SIGWINCH. SIGRTMIN is a feature unique to Linux.
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (f51efd0) to head (36d7a30).

Files with missing lines Patch % Lines
src/os/process_pool.cc 0.00% 5 Missing ⚠️
src/server/master.cc 50.00% 3 Missing ⚠️
src/server/worker.cc 81.81% 2 Missing ⚠️
src/server/manager.cc 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5778   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files         107      107           
  Lines       17261    17273   +12     
  Branches     3063     3064    +1     
=======================================
+ Hits        14323    14333   +10     
- Misses       2938     2940    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matyhtf matyhtf merged commit d38adf1 into master May 20, 2025
127 of 142 checks passed
@matyhtf matyhtf deleted the refactor-reopen-log-signal-2 branch May 20, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant