Skip to content

fix(component): fix animation error in post-collapsible rendered inside inactive tabs #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/v8
Choose a base branch
from
Open

fix(component): fix animation error in post-collapsible rendered inside inactive tabs #5502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c433d94
fix(component): fix animation error in post-collapsible when inside i…
May 15, 2025
0afbf0b
chore(chnageset): added a changeset
May 15, 2025
6016a48
chore(changeset): added a changeset
May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-buckets-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-components': patch
---

Resolved an issue where `post-accordion` components placed within inactive tab panels caused animation-related exceptions.
5 changes: 4 additions & 1 deletion packages/components/src/components/post-collapsible/post-collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ export class PostCollapsible {

await animation.finished;

animation.commitStyles();
const isVisible = this.host.offsetParent || this.host.offsetWidth || this.host.offsetHeight;
if (isVisible) {
animation.commitStyles();
}

return open;
}
Expand Down