-
Notifications
You must be signed in to change notification settings - Fork 18
chore(docs): add click blocker on stories #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still clickable links that aren't covered by the current implementation:
- card.stories.ts -
<p><a href="http://google.com">Interactive card</a></p>
- teaser.stories.ts -
<a href="#" class="btn btn-tertiary px-0">Button label <post-icon name="arrowright"></post-icon></a>
- popover.stories.ts -
<a href="#">Links</a>
packages/documentation/src/stories/raw-components/megadropdown/megadropdown.stories.ts
Outdated
Show resolved
Hide resolved
Posssible suggestion: add click blocker for Currently, onClick={e => e.preventDefault()} |
🦋 Changeset detectedLatest commit: ffad0b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
📄 Description
A few stories in the documentation had a click blocker on the links. I've created a common click blocker decorator and added it were needed for consistency.
🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
📝 Checklist