-
Notifications
You must be signed in to change notification settings - Fork 18
chore(styles): remove unused placeholder + cleanup #5428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5317-htmlcss-target-group
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f273b6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'm fine with the update, but...
We never documented this placeholder, which means it's interal code that should not be in use by any project. Therefore, removing it, because it's not used anymore, would not be a changeset worthy update, imo.
If I'm right, we would not need to add a changeset and we would also not need to document it in the migration guide as a breaking change.
If I'm wrong, it should be major
instead of minor
.
Please double check with @gfellerph or @alizedebray
I don’t have a strong opinion because it's probably not used at all, but I would consider it a major change since something was removed. It will be grouped with other major changes in v10 anyway. Also, since it was never documented, it doesn't need to be mentioned in the migration guide. |
|
📄 Description
I noticed the
%btn-transparent-background
was never used so I removed it and cleaned up the other placeholder files to remove unnecessary imports.🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
📝 Checklist