Skip to content

chore(styles): remove unused placeholder + cleanup #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5317-htmlcss-target-group
Choose a base branch
from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented May 5, 2025

📄 Description

I noticed the %btn-transparent-background was never used so I removed it and cleaned up the other placeholder files to remove unnecessary imports.

🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.


📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@leagrdv leagrdv requested review from a team as code owners May 5, 2025 13:39
@leagrdv leagrdv added the 🚂 PR train PR which follows another one. label May 5, 2025
@leagrdv leagrdv requested review from oliverschuerch and removed request for a team May 5, 2025 13:39
Copy link

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: f273b6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Minor
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-tokens Minor
@swisspost/design-system-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 1:50pm

@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 5, 2025

Related Previews

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm fine with the update, but...

We never documented this placeholder, which means it's interal code that should not be in use by any project. Therefore, removing it, because it's not used anymore, would not be a changeset worthy update, imo.

If I'm right, we would not need to add a changeset and we would also not need to document it in the migration guide as a breaking change.

If I'm wrong, it should be major instead of minor.

Please double check with @gfellerph or @alizedebray

@leagrdv leagrdv removed the 🚂 PR train PR which follows another one. label May 9, 2025
@alizedebray
Copy link
Contributor

In general, I'm fine with the update, but...

We never documented this placeholder, which means it's interal code that should not be in use by any project. Therefore, removing it, because it's not used anymore, would not be a changeset worthy update, imo.

If I'm right, we would not need to add a changeset and we would also not need to document it in the migration guide as a breaking change.

If I'm wrong, it should be major instead of minor.

Please double check with @gfellerph or @alizedebray

I don’t have a strong opinion because it's probably not used at all, but I would consider it a major change since something was removed. It will be grouped with other major changes in v10 anyway. Also, since it was never documented, it doesn't need to be mentioned in the migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants