Skip to content

Fix build #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix build #33

merged 1 commit into from
Nov 29, 2024

Conversation

MonsieurBon
Copy link

No description provided.

@hiddenalpha
Copy link
Member

(trivial) Maybe it would be worth fetching a few more (like somewhat in range 10-100) to cover other edge cases as well. 10-100 should't hurt at all IMHO.

Copy link
Member

@hiddenalpha hiddenalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait... Why do we change the pom version again?

@hiddenalpha hiddenalpha self-requested a review February 22, 2024 15:26
@MonsieurBon
Copy link
Author

Why do we change the pom version again?

Normally the commits from the release on the master are merged back to develop after the release. This failed here https://github.com/swisspost/apikana-java/actions/runs/8006164501 Therefore I'm merging these commits manually in this PR

@MonsieurBon
Copy link
Author

(trivial) Maybe it would be worth fetching a few more (like somewhat in range 10-100) to cover other edge cases as well. 10-100 should't hurt at all IMHO.

I was thinking about this as well. But we actually only need enough so that develop and master have a common ancestor and so git knows what to merge.

@MonsieurBon MonsieurBon merged commit 0d58e32 into swisspost:develop Nov 29, 2024
1 check passed
@MonsieurBon MonsieurBon deleted the fix-build branch November 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants