[DS-4136] Replace websocket w/ REST in Search RAG #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results67 tests 67 ✅ 32s ⏱️ Results for commit 9e22cb3. |
dnicodemus
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated view to replace the existing WebSocket implementation with a REST-based approach.
A new view,
DetailSearchRagView, has been added. It accepts the same parameters that were previously handled via the WebSocket and returns a response with the same structure to ensure backward compatibility:{
"message": str
}
Additionally, a new file
search_rag.pywas created to encapsulate a simplified version of the logic that was previously implemented inconsumer.py.Testing and Validation
This functionality was tested locally. I verified that the new REST endpoint behaves as expected, returning the correct structure and handling inputs consistently with the previous WebSocket-based implementation.
Type of Change
[x] New Feature / Enhancement (non-breaking change that add or improves functionality)