Recognize visionOS and DriverKit triples correctly #8898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes visionOS and DriverKit builds work correctly using the Swift Build backend.
jakepetroules
requested review from
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
owenv
reviewed
Jul 8, 2025
| @@ -43,6 +43,12 @@ public enum DarwinPlatform: Hashable { | |||
| /// watchOS, corresponding to the `watchos` OS name. | |||
| case watchOS(EnvironmentWithoutCatalyst) | |||
|
|
|||
| /// visionOS, corresponding to the `xros` and `visionos` OS names. | |||
There was a problem hiding this comment.
The triple implementation is vendor over from SwiftDriver so it's probably best to try to keep the two in sync
There was a problem hiding this comment.
Will take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes visionOS and DriverKit builds work correctly using the Swift Build backend.