-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix error handling for dump symbol graph #7141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please test |
5e3a032
to
77ac9aa
Compare
@swift-ci please test |
Ah, this is kinda interesting! Looks like this is already broken on Linux, but because we didn't actually look at errors, we never noticed? |
Actually, seems like it is also broken on macOS. |
Ah yes:
This is wrong of course, because we do not provide any modules for executables unless there's a test target depending on them. |
We'll need to merge #7143 first, so we don't always fail the existing tests. |
We were ignoring exit codes and output here, making the corresponding tests impossible to debug (and probably also making the command hard to use).
77ac9aa
to
f60cf97
Compare
@swift-ci please test |
@swift-ci please test windows |
We were ignoring exit codes and output here, making the corresponding tests impossible to debug (and probably also making the command hard to use).