Skip to content

Tests: adjust windows librarian test slightly #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Tests: adjust windows librarian test slightly #6450

merged 1 commit into from
Apr 18, 2023

Conversation

compnerd
Copy link
Member

Use the unsuffixed version of the tool's spelling. Although we should accept the suffixed variant (which clang does do!) the lookup in SPM currently does not properly handle the path lookup with that.

Use the unsuffixed version of the tool's spelling.  Although we should
accept the suffixed variant (which `clang` does do!) the lookup in SPM
currently does not properly handle the path lookup with that.
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@tomerd tomerd enabled auto-merge (squash) April 18, 2023 18:20
@tomerd tomerd merged commit 8f9556f into main Apr 18, 2023
@compnerd compnerd deleted the suffix branch April 18, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants