Skip to content

Add ignorable private flag to driver to match changes in frontend #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Apr 29, 2023

Resolves rdar://107638447

Frontend changes: swiftlang/swift#65336

@elsh elsh requested a review from artemcm April 29, 2023 00:36
@elsh
Copy link
Contributor Author

elsh commented Apr 29, 2023

@swift-ci test

@@ -64,6 +64,7 @@ enum SwiftFlags {
SwiftAPIDigesterOption = (1 << 17),
NewDriverOnlyOption = (1 << 18),
ModuleInterfaceOptionIgnorable = (1 << 19),
ModuleInterfaceOptionIgnorablePrivate = (1 << 20),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we now need to re-run makeOptions to get some flags to be updated with this flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elsh
Copy link
Contributor Author

elsh commented May 10, 2023

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented May 26, 2023

@swift-ci test

@elsh
Copy link
Contributor Author

elsh commented May 26, 2023

@swift-ci test Windows

@elsh elsh merged commit 5d24ff0 into main May 26, 2023
@elsh elsh deleted the es-flag branch May 27, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants