Skip to content

Tests: add VFS overlay for Dispatch #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jun 6, 2023

Introduce an additional compile time parameter for swift builds in the tests to pass along the VFS overlay for dispatch if the build directory is present. This ensures that we prefer the just built dispatch over the installed dispatch which is a prerequisite for permitting building Foundation et al with a build tree of dispatch when we have an installed toolchain.

Introduce an additional compile time parameter for swift builds in the
tests to pass along the VFS overlay for dispatch if the build directory
is present.  This ensures that we prefer the just built dispatch over
the installed dispatch which is a prerequisite for permitting building
Foundation et al with a build tree of dispatch when we have an installed
toolchain.
@compnerd
Copy link
Member Author

compnerd commented Jun 6, 2023

@swift-ci please test

@MaxDesiatov MaxDesiatov changed the title Tests: add vfs overlay for dipsatch Tests: add VFS overlay for Dispatch Jun 6, 2023
@MaxDesiatov MaxDesiatov requested review from etcwilde and grynspan June 6, 2023 20:17
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, but this is out of my wheelhouse so I'm not sure what the various effects might be.

@compnerd
Copy link
Member Author

compnerd commented Jun 8, 2023

This is needed as a dependency for swiftlang/swift-corelibs-libdispatch#794. This is a change to the configuration for the test suite and has no impact on the resulting binaries.

@compnerd compnerd merged commit 67488b5 into swiftlang:main Jun 8, 2023
@compnerd compnerd deleted the 5.9-fixes branch June 8, 2023 01:01
@compnerd compnerd restored the 5.9-fixes branch June 8, 2023 15:39
@compnerd compnerd deleted the 5.9-fixes branch June 8, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants