🍒[6.1] Handle multibyte path strings on Windows #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @compnerd |
|
@swift-ci please test |
rokhinip
approved these changes
Mar 7, 2025
compnerd
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
DispatchIOcreation routine incorrectly handles utf8 paths on Windows (e.g. provided byURL.withUnsafeFileSystemRepresentation).Original PR: #852
Risk: Medium. The affected code is local for
io.csource and has relatively narrow and clear usage.Testing: The prototype was tested in live product, and the final solution was checked locally with unit testing based on
dispatch_io.ctest code.Reviewer: @compnerd