Skip to content

Add more comments for #endif in .h file. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

lamtrinhdev
Copy link
Contributor

This is a long .h file. I would like to are more comment for #endif.

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

Base on the old PR #837 , I moved the the new PR with single commit. Please help me to review it.

Thanks,
Lam

@rokhinip
Copy link
Contributor

rokhinip commented Aug 2, 2024

Please kick off CI and then merge it.

@lamtrinhdev
Copy link
Contributor Author

@swift-ci please test

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

I do not have permission to call @swift-ci and merge. Could you please support me?

Thanks,
Lam

@rokhinip
Copy link
Contributor

rokhinip commented Aug 2, 2024

I can do that but we need to get you access if you are planning to continue contributing because I cannot be doing this for every PR you put up

@rokhinip
Copy link
Contributor

rokhinip commented Aug 2, 2024

@swift-ci please test

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

I got it. Thank you for your support.

Thanks,
Lam

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

Could you help me to merge the PR?

Thanks,
Lam

@rokhinip rokhinip merged commit 7ee5ee9 into swiftlang:main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants