Skip to content

Correct the comment DISPATCH_MACH_MSG_DESTRUCTOR_VM_DEALLOCATE at mach_private.h #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lamtrinhdev
Copy link
Contributor

Correct the comment DISPATCH_MACH_MSG_DESTRUCTOR_VM_DEALLOCATE at mach_private.h

Correct the comment for DISPATCH_MACH_MSG_DESTRUCTOR_VM_DEALLOCATE
@lamtrinhdev
Copy link
Contributor Author

lamtrinhdev commented Jul 26, 2024

Dear @ktoso , @rokhinip ,

Could you help me to review it?

Thanks,
Lam

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

Thanks for the review! Can you help me to run @swift-ci and merge this too please? I don't have write access.

Thanks,
Lam

@rokhinip
Copy link
Contributor

@swift-ci please test and merge

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

It looks like the test that does not run, is it right?

Thanks,
Lam

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

Could you please help me to run @swift-ci again? It seems to be not working.

Thanks,
Lam

@rokhinip
Copy link
Contributor

@swift-ci please test

@lamtrinhdev
Copy link
Contributor Author

Dear @rokhinip ,

Thank you for your support. It is passed al. Could you please help me to merge it?

Thanks,
Lam

@rokhinip rokhinip merged commit 85369ba into swiftlang:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants