Skip to content

Issue #507 - Episode 14 - Added guidance for RStudio users when Git.exe path not pre-filled #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 26, 2019
Merged

Issue #507 - Episode 14 - Added guidance for RStudio users when Git.exe path not pre-filled #531

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ae3059
More detail on how to find git executable
richmccue May 24, 2018
655d8ee
Added html bold tags to try to fix formatting issue
richmccue May 25, 2018
3634cf8
Copied text to 2nd location so hopefull it will display now
richmccue May 25, 2018
6cc13c4
Fixed 2 section header sizes
richmccue May 25, 2018
993e90f
Trying to made code snipped mono space
richmccue May 25, 2018
41310ea
2nd try at monospace font
richmccue May 25, 2018
616c043
Block font and replaced code accidently deleted
richmccue May 25, 2018
5204eb3
Added clarifying text to the find git exe section
richmccue May 25, 2018
8d20168
Added more claritying text in git exe area
richmccue May 25, 2018
309e7f8
Added single quotes for more monospace code
richmccue May 25, 2018
543dd82
I've updated the language around making sure that git is installed...
richmccue Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions _episodes/14-supplemental-rstudio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,29 @@ our computer, we choose the option "Existing Directory":
> option on this menu. That is what you would click on if you wanted to
> create a project on your computer by cloning a repository from GitHub.
> If that option is not present, it probably means that RStudio doesn't know
> where your Git executable is. See
> [this page](https://stat545-ubc.github.io/git03_rstudio-meet-git.html)
> for some debugging advice. Even if you have Git installed, you may need
> where your Git executable is, and you won't be able to progress further
> in this lesson until you tell RStudio where it is.
> ### Find your Git Executiable
> First let's make sure that Git is installed on your computer.
> Open your shell on Mac or Linux, or on Windows open the command prompt
> and then type:
> - `which git` (Mac, Linux)
> - `where git` (Windows)
>
> If there is no version of Git on your computer, please either install [Git](https://git-scm.com/downloads/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about referring to https://carpentries.github.io/workshop-template/#git here so that we do not need to maintain extra instructions here at all? https://swcarpentry.github.io/git-novice/setup.html is already doing that as well.

Copy link
Contributor

@munkm munkm Jan 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively if the directions are clear we can merge this PR and open an issue for another new contributor to update this URL. richmccue has already spent a lot of time on this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which can not be recovered unfortunately, and therefore should not be part of the decision when what gets merged ;-)

I don't mean this harshly at all; Please don't get me wrong! I'm grateful to @richmccue for alerting us to the problem and for providing a fix :-) Just pointing out that previous maintainers choose to refer to the setup info that's maintained centrally.

Will test this on the weekend and report back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the helpful wikipedia link.

I agree that this link should point to the same instructions as the setup to be consistent with the rest of the lesson. I do not think that that merging this PR should be blocked by this link being inconsistent.

> or [GitHub](https://desktop.github.com/) now. Next open your shell or command prompt
> and type `which git` (Mac, Linux), or `where git` (Windows).
> Copy the path to the git executable.
>
> e.g. On one Windows computer which had GitHub Desktop installed on it, the path was:
> `C:/Users/UserName/AppData/Local/GitHubDesktop/app-1.1.1/resources/app/git/cmd/git.exe`
>
> NOTE: The path on your computer will be somewhat different.
> ### Tell RStudio where to find GitHub
> In RStudio, go to the `Tools` menu > `Global Options` > `Git/SVN` and then
> browse to the git executable you found in the command prompt or shell. Now restart
> RStudio.
> Note: Even if you have Git installed, you may need
> to accept the XCode license if you are using macOS.
{: .callout}

Expand Down