Skip to content

feat(swc/plugin_runner): implement initial load for wasm32 #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Mar 24, 2022

Description:

This was unexpectedly bit tricky due to small bumps across various places. Anyway, this PR covers basic load execution paths for the plugin with native runtime (wasm host). It still uses current experimental resolver approach which accepts redundant bytes copy between js -> wasm.

Also, there are couple of issues blocks actual plugin executions yet:

  • wasi binary init fails
  • transformexecutor need to be updated to work with wasmer::js
  • string-cache upstream fix needed

Related issue (if exists):

@kwonoj kwonoj force-pushed the feat-wasm-plugin-wasm-host-resolve branch from d456088 to cd87ece Compare March 24, 2022 18:13
@kwonoj kwonoj force-pushed the feat-wasm-plugin-wasm-host-resolve branch from cd87ece to 8c5b6e6 Compare March 24, 2022 18:23
@kwonoj kwonoj force-pushed the feat-wasm-plugin-wasm-host-resolve branch from 8c5b6e6 to af914c0 Compare March 24, 2022 18:47
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_plugin_runner
  • swc

@kdy1 kdy1 enabled auto-merge (squash) March 25, 2022 06:38
@kdy1 kdy1 added this to the v1.2.161 milestone Mar 25, 2022
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 161353c into swc-project:main Mar 25, 2022
@kwonoj kwonoj deleted the feat-wasm-plugin-wasm-host-resolve branch March 25, 2022 08:31
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants