CLI: build with dist
#1593
Merged
CLI: build with dist
#1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
3 times, most recently
from
0ce1afa to
fa19730
Compare
svix-onelson
added a commit
that referenced
this pull request
Dec 30, 2024
This is to help clarfiy what the binary actually is among the rest of the svix tooling in the repo. Looking forward, this will also help to keep the naming scheme consistent between the binary, the package name, and the updater while handling distribution via `dist` (pending PR: #1593)
svix-onelson
added a commit
that referenced
this pull request
Dec 30, 2024
This is to help clarify what the binary actually is among the rest of the svix tooling in the repo. Looking forward, this will also help to keep the naming scheme consistent between the binary, the package name, and the updater while handling distribution via `dist` (pending PR: #1593)
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
from
fa19730 to
c74a891
Compare
svix-onelson
added a commit
that referenced
this pull request
Dec 30, 2024
This is to help clarify what the binary actually is among the rest of the svix tooling in the repo. Looking forward, this will also help to keep the naming scheme consistent between the binary, the package name, and the updater while handling distribution via `dist` (pending PR: #1593)
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
2 times, most recently
from
e227982 to
b4f897b
Compare
svix-onelson
changed the base branch from
main
to
onelson/track-codegen-sources-rust
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
2 times, most recently
from
39b036e to
b998afe
Compare
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
from
b998afe to
c5094d5
Compare
svix-onelson
force-pushed
the
onelson/cli-build-with-dist
branch
from
c5094d5 to
66042cd
Compare
svix-onelson
commented
Dec 31, 2024
tasn
reviewed
Dec 31, 2024
svix-onelson
commented
Dec 31, 2024
tasn
reviewed
Dec 31, 2024
tasn
reviewed
Dec 31, 2024
tasn
reviewed
Dec 31, 2024
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags, import/export, and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags, import/export, and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 Since the version number appears in the script-based installer URLs, `tools/bump_version.js` has been updated to also target this readme. More sections will be added to describe `homebrew`/`cargo` installation once available.
svix-onelson
added a commit
that referenced
this pull request
Dec 31, 2024
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags, import/export, and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 Since the version number appears in the script-based installer URLs, `tools/bump_version.js` has been updated to also target this readme. More sections will be added to describe `homebrew`/`cargo` installation once available.
tasn
approved these changes
Jan 2, 2025
tasn
reviewed
Jan 2, 2025
svix-onelson
added a commit
that referenced
this pull request
Jan 2, 2025
The text in this readme is based largely on the one from the old Go CLI. Some sections have been removed since support for the thing being mentioned was not carried forward (e.g. `--data-*` flags, import/export, and also piping json bodies in which apparently our new clap-based parser doesn't do). Installer instructions are limited to the initial set offered via #1593 Since the version number appears in the script-based installer URLs, `tools/bump_version.js` has been updated to also target this readme. More sections will be added to describe `homebrew`/`cargo` installation once available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds workflows and supporting configs to use dist for building and publishing binaries for the CLI.
To lean towards dist's happy path, a top-level
Cargo.tomldefines a workspace including any cargo projects we want to build and distribute (currently justsvix-cli).The
dist-workspace.tomlincludes various parameters set bydist initto configure the generation of.github/workflows/release.yml.dist-workspace.tomlcan be edited manually, but therelease.ymlshould only be changed viadist generate.Installers
Currently, the
shell,powershellandmsiinstallers are configured.distalso provides:npmhomebrew(we'll definitely enable this one once we know everything looks good)The current selection are essentially "curl to sh" (and the Windows equivalent) like is commonly done for
rustupand seemed like the closest thing we'd see to a "hello world." My plan is to enable more in subsequent releases.The
msiinstaller includes a full installer wizard type deal.Releasing
These notes are for the folks doing releases once this lands. The gist is:
Releaseworkflow (which is managed bydist) specifying the tag.The
Releaseworkflow uses the tag to find the draft release so it can publish its build artifacts there.The last thing this workflow does is mark the Release as published, so be sure to update the release notes and so on before running this workflow.