CLI: skip setting file mode for Windows #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CLI creates a config file for the user, we use `600` unix permissions to ensure only the user can read/write the file. Setting the file mode like this is only possible like this on unix-like systems so this breaks the build for Windows. This diff splits the opening of the file into platform-specific functions, one for `windows` which doesn't set the file mode. The `unix` flavored function does what we had in the first place. In <https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfile2> there's mention of ACL being inherited from the parent directory. My understanding is `%APPDATA%` should only be accessible by the named user, so I'm hoping the defaults are correct for our use case.
svix-onelson
force-pushed
the
onelson/cli-skip-file-mode-windows
branch
from
dd1a145 to
894985e
Compare
svix-aaron1011
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CLI creates a config file for the user, we use
600unix permissions to ensure only the user can read/write the file.Setting the file mode like this is only possible like this on unix-like systems so this breaks the build for Windows.
This diff splits the opening of the file into platform-specific functions, one for
windowswhich doesn't set the file mode. Theunixflavored function does what we had in the first place.In https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfile2 there's mention of ACL being inherited from the parent directory. My understanding is
%APPDATA%should only be accessible by the named user, so I'm hoping the defaults are correct for our use case.