kotlin: Replace most query param classes with generated ones #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-jplatte
force-pushed
the
jplatte/kotlin-gen-list-options
branch
from
6525c70 to
78eba9e
Compare
|
Yeah, no need to mention that. It's an implementation detail that was never public, and anyhow we won't change the server value anyway. |
svix-james
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and clean up the remaining ones to prepare for future replacement.
Also leave the default for the
limiton pagination APIs up to the server. I don't think we need to mention this in the changelog since so far the default has been the same as on the server side; however if we were to change the limit for some API on the server side, it makes much more sense to me that the new default would apply immediately and for everyone who doesn't specify it, rather than requiring a libs update for Kotlin users.Part of https://github.com/svix/monorepo-private/issues/9576.