js: Enforce uniform formatting #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-lucho
approved these changes
Dec 18, 2024
svix-jplatte
added a commit
that referenced
this pull request
Dec 18, 2024
Like #1574. We want to replace some files with auto-generated ones, to reduce the diff and make it readable once it's generated, we should apply auto-formatting at all times. I tried setting up a gradle plugin for this, but unfortunately things are a bit broken for me locally, so that didn't work out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to commit more generated code soon that needs auto-formatting to look good. Seems like we didn't have auto-formatting set up correctly so we had some overly long lines and a mix of two-space and four-space indentation. This PR fixes that, and updates CI to error on unformatted files.