Skip to content

Fix README #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix README #1499

wants to merge 1 commit into from

Conversation

jaymell
Copy link
Contributor

@jaymell jaymell commented Nov 1, 2024

Wrong verb.

Wrong verb.
@jaymell jaymell requested a review from a team as a code owner November 1, 2024 17:15
@@ -390,7 +390,7 @@ One of our main goals with open sourcing the Svix dispatcher is ease of use. The
This is why this code has been adjusted before being released, and some of the features, optimizations, and behaviors supported by the hosted dispatcher are not yet available in this repo. With that being said, other than some known incompatibilities, the internal Svix test suite passes. This means they are already mostly compatible, and we are working hard on bringing them to full feature parity.

# Re-driving Redis DLQ
We have an undocumented endpoint for re-driving failed messages that are DLQ'ed. You can do this by calling `POST /api/v1/admin/redrive-dlq/`.
We have an undocumented endpoint for re-driving failed messages that are DLQ'ed. You can do this by calling `PUT /api/v1/admin/redrive-dlq/`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH we probably should fix the code, not the doc here. It should be a POST, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh ignore me. I got confused. Yeah you're right, I had it backward from a prior change.

@jaymell
Copy link
Contributor Author

jaymell commented Nov 1, 2024

Closing. This is correct.

@jaymell jaymell closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants