More redis refactors #1477
Merged
More redis refactors #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of the needless indirection/structs that were obscuring what should be a pretty simple thing -- i.e., the different variants for `ConnectionManager`s and `RedisConnection`s. Note also that by moving some of the `query_async` calls to the `Cmd` rather than the connection, we can completely remove the `*Connection` types and associated macros. There's definitely some more cleanup that can be done here, but I think this is good for one PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of the needless indirection/structs that were obscuring what should be a pretty simple thing -- i.e., the different variants for
ConnectionManagers andRedisConnections.Note also that by moving some of the
query_asynccalls to theCmdrather than the connection, we can completely remove the*Connectiontypes and associated macros.There's definitely some more cleanup that can be done here, but I think this is good for one PR.