Skip to content

Server: Add 'expunge' parameter to event-type deletion route #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

svix-aaron1011
Copy link
Contributor

This already exists in the hosted svix.com product

Fixes #1457

@svix-aaron1011 svix-aaron1011 requested a review from a team as a code owner October 1, 2024 22:33
svix-onelson
svix-onelson previously approved these changes Oct 2, 2024
Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@svix-onelson svix-onelson dismissed their stale review October 2, 2024 04:40

Looks like it needs an openapi spec rebuild

This already exists in the hosted svix.com product
@svix-aaron1011 svix-aaron1011 force-pushed the aaron1011/event-type-expunge branch from 18bed1e to 2eeda89 Compare October 2, 2024 14:47
@svix-aaron1011 svix-aaron1011 merged commit 222d5ca into main Oct 2, 2024
6 checks passed
@svix-aaron1011 svix-aaron1011 deleted the aaron1011/event-type-expunge branch October 2, 2024 15:44
@michabbb
Copy link

michabbb commented Oct 2, 2024

Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server] delete event-type does not delete anything
4 participants