Libs(Go): get go tests running in CI #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/go-ci
branch
4 times, most recently
from
f3bc021 to
a48de8f
Compare
We've got a handful of unit test that could catch problems when the Go sources are changing, so let's run them as a part of CI. This doesn't re-run the OpenAPI codegen (but it could later). It would be nice to know if the checked in sources were not aligned with whatever the generator produces, for example if a recent spec bump PR neglected to check them in.
svix-onelson
force-pushed
the
onelson/go-ci
branch
from
a48de8f to
59f3e98
Compare
svix-lucho
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a handful of unit test that could catch problems when the Go sources are changing, so let's run them as a part of CI.
This doesn't re-run the OpenAPI codegen (but it could later). It would be nice to know if the checked in sources were not aligned with whatever the generator produces, for example if a recent spec bump PR neglected to check them in.