Skip to content

feat(preprocess): check preprocess dependencies for anomalies #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Oct 15, 2023

depending on itself

this is usually a sign for a bad setup/import, see #763

depending on many files

all these files have to be read separately and changing one of them leads to a hot reload of the component. Depending on a few files is ok, but many cause issues.

Messages get added as extra compiler warnings using the vite-plugin-svelte-preprocess- prefix. This way users can opt to ignore them via onwarn hook.

Are these checks too rigid and do we need FAQ entries and link them in the messages?

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some message nits

@dominikg dominikg merged commit 261f571 into main Oct 16, 2023
@dominikg dominikg deleted the feat/check-preprocessor-deps branch October 16, 2023 13:19
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants