feat: provide fetch
to reroute
#13549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides
fetch
as an argument toreroute
, so that you can get the same benefits as thefetch
provided toload
functions from it. This is important (among other things) because else you might not be able to forward cookies on the server which influence where to go to.The
respond.js
diff looks beefier than it is. Basically theevent
object is moved on top so that it's created before thereroute
, because thefetch
method passed to it needs to know aboutevent
. The biggest change is about cookies, which are now first created without knowing about the trailing slash, so setting new cookies (for which this is important) will wait until after a route is known.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.