-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix(no-shadow): ignore {#snippet}
if it uses under component
#992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1a779d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
37cfbd1
to
b45d9ec
Compare
{#snippet}
if it uses unser component.{#snippet}
if it uses under component
b45d9ec
to
1eff52b
Compare
commit: |
2dcd746
to
d19ddfc
Compare
d19ddfc
to
1a779d1
Compare
Thank you for working on this. However, when I saw your implementation on this PR and #995, I had second thoughts. I think it would be better to make the snippet declaration not add variables (remove variables) if they are declared in a component and the declared identifier is not used elsewhere. That way, I think it probably won't affect any other rules. What do you think? |
How are the arguments passed to that snippet handled? |
They should be added to the scope and processed. |
I think it's good! |
close: #871