remove eslint-plugin-import #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
eslint-plugin-import
branch
from
ad6d9de to
ec2f8d2
Compare
antony
approved these changes
Jun 9, 2023
Rich-Harris
approved these changes
Jun 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-importreally doesn't add anything.import/no-duplicatescan be replaced withno-duplicate-importsand the TypeScript compiler's typechecking will catch all the others. Removing these unnecessary rules will speed up linting as well as reducing the number of dependencies in our projects.eslint-plugin-importpulls in 75 transitive dependencies: https://npm.anvaka.com/#/view/2d/eslint-plugin-import.