Mark most preview specific service as internal #7871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,9 @@ | |||
|
|
|||
| namespace Sulu\Bundle\PreviewBundle\Preview\Object; | |||
|
|
|||
| /** | |||
| * @internal No BC promises are given for this class. It may be changed or removed at any time. | |||
| */ | |||
| interface PreviewObjectProviderRegistryInterface | |||
There was a problem hiding this comment.
this will mostly be replaced by a service locator in one of @mamazu PRs.
wachterjohannes
approved these changes
Mar 31, 2025
alexander-schranz
force-pushed
the
feature/mark-preview-services-as-internal
branch
from
ddfefbd to
f0bea05
Compare
alexander-schranz
force-pushed
the
feature/mark-preview-services-as-internal
branch
from
28684b6 to
6652a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Mark most preview specific services as internal.
Why?
There are some deep connections between service in the preview bundle, as we should keep the
Public APIas small as possible to make the maintainance here easier I suggest to mark most of the Preview specific services and how it is rendered asinternalthis may make it easier in future to single kernel setup.The only connection point for bundles is mostly the
PreviewObjectProviderInterface/PreviewDefaultsProviderInterfaceall other services are not used by devs.