Skip to content

Thumbprint the UV assets at the directory level #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Mar 7, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.953% when pulling 7c34637 on thumbprint-uv into 5a6f115 on master.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage decreased (-0.1%) to 95.833% when pulling bc21edd on thumbprint-uv into 5a6f115 on master.

@cbeer cbeer force-pushed the thumbprint-uv branch 3 times, most recently from 3b1fd13 to e527868 Compare March 7, 2018 22:50
# (see https://github.com/UniversalViewer/universalviewer/issues/481)
#
# In the meantime, to bust browser caches we're calculating a unique
# thumbprint for the UV assets ourselves

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

# UV is deployed outside the asset pipeline
# (see https://github.com/UniversalViewer/universalviewer/issues/481)
#
# In the meantime, to bust browser caches we're calculating a unique

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

Copy link
Contributor

@camillevilla camillevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, comments ✨

@camillevilla camillevilla merged commit 02f1bc8 into master Mar 7, 2018
@camillevilla camillevilla deleted the thumbprint-uv branch March 7, 2018 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants