Feature/custom translations frontend #857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
10cd759 to
d285bd1
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
4ff16fa to
81fd1ed
Compare
AntoLC
reviewed
Apr 9, 2025
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
b9b16aa to
06b91a1
Compare
Part of customization PoC
Part of customization PoC
Part of customization PoC
Part of customization PoC
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
06b91a1 to
af92119
Compare
AntoLC
reviewed
Apr 22, 2025
| if (request.method().includes('GET')) { | ||
| await route.fulfill({ | ||
| json: { | ||
| ...config, |
There was a problem hiding this comment.
Suggested change
| ...config, | |
| ...CONFIG, |
There was a problem hiding this comment.
The problem that I see is that we change the pattern of the application, all the features used /api/ to have a clear separation of concern, and we use react-query.
By leveraging react-query, no need to do tricks with useRef as react-query has an inner cache, it will be more readable by reducing conditions and try catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to inject/override translations at runtime.
Moves contents of
docs/theming.mdintodocs/customization.mdfor a more unified documentation.