feat: allow to profile inline functions #2260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/core/executor/src/executor.rs
Outdated
| } | ||
| let stack_event = match i.opcode { | ||
| // A JAL instruction should push the return address onto a return-address | ||
| // stack (RAS) only when rd=x1/x5. |
There was a problem hiding this comment.
Suggested change
| // stack (RAS) only when rd=x1/x5. | |
| // stack (RAS) only when rd=x1 or rd=x5. |
leruaa
force-pushed
the
aurelien/gro2-498-add-inlined-functions-to-profiler
branch
from
16c175a to
be86da1
Compare
ratankaliani
reviewed
May 5, 2025
crates/core/executor/src/profiler.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| // Pop inline functions when the current PC is not in theirs range |
There was a problem hiding this comment.
Suggested change
| // Pop inline functions when the current PC is not in theirs range | |
| // Pop inline functions when the current PC is not in the range of the function stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's sometimes useful to be able to have inlines function shown in the call stack when profiling a program
Solution
TRACE_INLINE_FUNCTIONenv variable to enable inline functions trackingJALandJALRopcodes to correctly handle recursive functionsPR Checklist