feat: disallow SP1 to be ran in debug #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leruaa
force-pushed
the
aurelien/check-sp1-sdk-is-built-in-release
branch
from
581d6cf to
67b88fc
Compare
ratankaliani
reviewed
Apr 9, 2025
ratankaliani
reviewed
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Teams that run benchmarks might forget the release flag and see degraded performance. To avoid that, we want to disallow provers to be ran in debug in CPU and Cuda mode.
Solution
Panics when the CPU and Cuda provers are instantiated if
sp1-sdkis build in debug. It's not an issue with the network prover as progams are executed on a remote cluster.