chore(ci): use gh release and rm unused nightly logic #2182
+71
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtyy
force-pushed
the
n/cleanup-release-flow
branch
from
98d2bbd to
4c23308
Compare
nhtyy
changed the title
nhtyy
commented
Mar 28, 2025
.github/workflows/release.yml
Outdated
| @@ -6,7 +6,6 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
This should only be ran on main
nhtyy
commented
Mar 28, 2025
| with: | ||
| script: | | ||
| const createTag = require('./.github/scripts/create-tag.js') | ||
| await createTag({ github, context }, process.env.TAG_NAME) |
There was a problem hiding this comment.
tag name should only be the version were making
nhtyy
commented
Mar 28, 2025
|
|
||
| - name: Build changelog | ||
| id: build_changelog | ||
| uses: mikepenz/release-changelog-builder-action@v4 | ||
| with: | ||
| fromTag: ${{ env.IS_NIGHTLY && 'nightly' || '' }} |
There was a problem hiding this comment.
looks for the last release by default
nhtyy
commented
Mar 28, 2025
.github/workflows/release.yml
Outdated
| uses: actions/setup-go@v5 | ||
| # Install rust and go. | ||
| - name: Setup CI | ||
| uses: ./.github/actions/setup |
There was a problem hiding this comment.
Installs go and rust and stuff
nhtyy
force-pushed
the
n/cleanup-release-flow
branch
from
4c23308 to
3ff19f2
Compare
ctian1
approved these changes
Mar 28, 2025
nhtyy
force-pushed
the
n/cleanup-release-flow
branch
13 times, most recently
from
74902d6 to
53e87df
Compare
nhtyy
force-pushed
the
n/cleanup-release-flow
branch
from
53e87df to
10b4c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.