perf: finer grained recursion compilation lock #2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwen01
force-pushed
the
yuwen/fix-cache-locking
branch
from
d65cb0f to
759966c
Compare
nhtyy
force-pushed
the
yuwen/fix-cache-locking
branch
from
f8f21d0 to
5302f37
Compare
nhtyy
approved these changes
May 7, 2025
yuwen01
changed the title
yuwen01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of holding the program cache lock while compiling a recursion program, release it after checking the cache and re-acquire when inserting a compiled program into the cache.