Add IP family support to cableengine #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr3320/yboaron/cable_ipfamily |
yboaron
force-pushed
the
cable_ipfamily
branch
from
eb93fdd to
1bf97a3
Compare
yboaron
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
tpantelis
requested changes
Feb 27, 2025
There was a problem hiding this comment.
FYI I submitted #3321 to add unit test coverage in preparation for the IPv6 changes. As a bonus, I'm very familiar with the code now so I can tackle the IPv6 changes later.
There was a problem hiding this comment.
I think we should focus first on adding IPv6/dual-stack support for single CNI/cable driver combination (I guess we can start with OVN/libreswan), and then add support for the rest of CNIs, cables
yboaron
force-pushed
the
cable_ipfamily
branch
3 times, most recently
from
b7fab87 to
11da553
Compare
tpantelis
requested changes
Mar 3, 2025
The implementation of IP family in Libreswan will be handled in a follow up PR. Signed-off-by: Yossi Boaron <[email protected]>
tpantelis
approved these changes
Mar 3, 2025
|
🤖 Closed branches: [z_pr3320/yboaron/cable_ipfamily] |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.