Rename lldb-vscode to lldb-dap in Debugging doc #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was renamed to better signal that it is generic, not just for VS Code. llvm/llvm-project#69264 Also when I ported some of these instructions back to LLVM, reviewers suggested I use the "attach" mode instead. https://github.com/llvm/llvm-project/tree/main/lldb/tools/lldb-dap#connect-to-a-debug-server-on-the-current-machine So I've done that too. For our purposes it's the same effect, but technically we are attaching not launching.
|
Thanks! And yes, I noticed this myself last night, as llvm-vscode is in our modified list of LLVM_DISTRIBUTION_COMPONENTS and CMake didn't recognise the target anymore. Will push separate patch for that right after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was renamed to better signal that it is generic, not just for VS Code.
llvm/llvm-project#69264
Also when I ported some of these instructions back to LLVM, reviewers suggested I use the "attach" mode instead.
https://github.com/llvm/llvm-project/tree/main/lldb/tools/lldb-dap#connect-to-a-debug-server-on-the-current-machine
So I've done that too.
For our purposes it's the same effect, but
technically we are attaching not launching.