Skip to content

Split source JS into multiple files, root ant build update #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2015
Merged

Split source JS into multiple files, root ant build update #12

merged 10 commits into from
May 22, 2015

Conversation

dmytrolev
Copy link
Contributor

hello,

i am working on some update of javascript library. currently i've split single file into multiple for easier maintenance and i try to make root ant up to date.

this is work in progress, can you please review it ?

i have some special questions:

  1. what do you think about relations betwean grunt in js library and ant in the root ? i hope we could use these tools more independantly. currently i had to make a bridge calls for windows, unix and mac for each task.
  2. dependancies download for exmple war is not working. maybe ivy can help here ? is there a good way to obtain servlet-api jar ?
  3. what do you think about modernizing some of functions ? like json layout - it does everything by hand - but now JSON is available in modern browsers, we can use it.
  4. what do you think about making LogEvent's message more broad, and allow it to be an object ? i use it for solr logging - this way i can create log event to post onto my server with message, and screen width and height as server-understandble numbers, this seems to be handy.

thank you

@stritti
Copy link
Owner

stritti commented May 22, 2015

Hi,

Many thanks for your great work.

It is a really good idea to get rid of ant for JavaScript part. Starting implementing this library, there was no grunt available. I still learn grunt :)
The servlet-api.jar is normally provided by the servlet container. Yes we could use Maven or Ivy..
Feel free to modernize, shure. Would be glad to see how the library is improved!

stritti added a commit that referenced this pull request May 22, 2015
Split source JS into multiple files, root ant build update
@stritti stritti merged commit 1910361 into stritti:master May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants