Skip to content

fix travis script typo #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2015
Merged

fix travis script typo #10

merged 3 commits into from
Apr 1, 2015

Conversation

dmytrolev
Copy link
Contributor

No description provided.

@dmytrolev
Copy link
Contributor Author

there are planty of jshint errors during build invocation. what politics should be used to fix those ? for example i am not a fan of ===. should this test be switched off or fixed in code ?

@stritti
Copy link
Owner

stritti commented Mar 31, 2015

Hi @dimalev ,

Many thanks for your support to fix the scripts. Probably we could disable the test in first step and postpone the improved style?

@stritti
Copy link
Owner

stritti commented Mar 31, 2015

@dimalev currently at your Pullrequest the file bower.json could not be found by bower. Do you have an idea why?

@dmytrolev
Copy link
Contributor Author

yes, i am working on it

@stritti
Copy link
Owner

stritti commented Apr 1, 2015

really great. Thanks a lot for your support.

@dmytrolev
Copy link
Contributor Author

so, it kinda works

as i understand - it creates bundles for you, but those are not published anywhere, so it just checks that "it builds successfuly"

what about porting js part of project to somehow pure nodejs ?

@stritti
Copy link
Owner

stritti commented Apr 1, 2015

You think about porting log4js? There is already a forked port at log4js-node on GitHub.
Or do you want to change the build environment? I originally came from Java and would be pleased for any support to improve log4js!

stritti added a commit that referenced this pull request Apr 1, 2015
@stritti stritti merged commit 0deb433 into stritti:master Apr 1, 2015
@dmytrolev
Copy link
Contributor Author

java is kool
yes, i think about changing build environment. javascript tests in java enviroment look .... fun :)

what do you think about adding some kind of solr log4js handlers' configurations and tutorials how to use those ? should be lots of fun :)

@stritti
Copy link
Owner

stritti commented Apr 2, 2015

Hi @dimalev ,

that would be really good to build the JavaScript part with JS-Tools. Years ago ther were no such tools for that.
If you are interessted in doing more at the project I would invite you to improve it.

Regards from Germany,

Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants